Skip to content
Jump to bottom

Providers #13

Merged
merged 10 commits into from
Nov 15, 2024
Merged

Providers #13

merged 10 commits into from
Nov 15, 2024

Conversation

morga471
Copy link
Contributor

@morga471 morga471 commented Nov 7, 2024

No description provided.

@morga471 morga471 self-assigned this Nov 7, 2024
@morga471 morga471 marked this pull request as ready for review November 7, 2024 16:57
nangu001
nangu001 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nangu001
nangu001 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morga471
Copy link
Contributor Author

morga471 commented Nov 8, 2024 •
edited

This PR has exploded in size and complexity.
all version vars are now hoisted and pulled from default-versions.
all cluster module uses are now identical, I have copied my module defs to the other clusters
misc other improvements

nangu001
nangu001 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morga471 morga471 merged commit c82b7ce into master Nov 15, 2024
@morga471 morga471 deleted the providers branch November 15, 2024 19:12
Sign in to join this conversation on GitHub.
Reviewers

@nangu001 nangu001 nangu001 approved these changes

@mcgin314 mcgin314 Awaiting requested review from mcgin314

@patel385 patel385 Awaiting requested review from patel385

@munoz333 munoz333 Awaiting requested review from munoz333

Assignees

@morga471 morga471

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morga471 @nangu001